Merge e8bebe0b03 into e1b3fa242c

[postprocessor/ffmpeg] Allow options for mp3
Why? Options like `preferredquality` are ignored when postprocessing mp3s. What? Remove `mp3` from the list of `filecodec` values to check for in the "lossless" condition unless `preferredquality` is unspecified.
2024-12-19 07:02:06 +00:00 · 2024-07-25 11:39:08 +00:00 · 2023-08-17 07:48:20 -07:00
1 changed files with 4 additions and 1 deletions
--- a/youtube_dl/postprocessor/ffmpeg.py
+++ b/youtube_dl/postprocessor/ffmpeg.py
@ -276,7 +276,10 @@ class FFmpegExtractAudioPP(FFmpegPostProcessor):
                acodec = 'copy'
                extension = 'm4a'
                more_opts = ['-bsf:a', 'aac_adtstoasc']
-            elif filecodec in ['aac', 'flac', 'mp3', 'vorbis', 'opus']:
+            elif (
+                filecodec in ['aac', 'flac', 'vorbis', 'opus'] or
+                (filecodec == 'mp3' and self._preferredquality is None)
+            ):
                # Lossless if possible
                acodec = 'copy'
                extension = filecodec